Skip to content

Comments

Fix e2e CI test not running on PRs#46

Merged
nhorton merged 8 commits intomainfrom
claude/fix-e2e-ci-test-fgY7u
Jan 15, 2026
Merged

Fix e2e CI test not running on PRs#46
nhorton merged 8 commits intomainfrom
claude/fix-e2e-ci-test-fgY7u

Conversation

@nhorton
Copy link
Contributor

@nhorton nhorton commented Jan 15, 2026

No description provided.

nhorton and others added 8 commits January 14, 2026 17:30
Replace Markdown with JSON array - CLA Assistant action
expects JSON format for storing signatures.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CLA Assistant expects { "signedContributors": [] } format,
not a plain array.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Per CLA Assistant docs: "You do not need to create this file manually.
Our workflow will create the signature file if it does not already exist.
Manually creating this file will cause the workflow to fail."

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove the `branches: ["*"]` filter from the pull_request trigger.
The glob pattern `*` doesn't match `/`, so PRs targeting branches
with slashes (like feature/...) were not triggering the workflow.

By removing the filter, the workflow now runs on all PRs regardless
of target branch, while still not running on post-merge to main
(since there's no push trigger).
@nhorton nhorton merged commit 4dfdc2c into main Jan 15, 2026
2 checks passed
@nhorton nhorton deleted the claude/fix-e2e-ci-test-fgY7u branch January 15, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants